leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-497018429 > should it consider a DataSegment instance and a SegmentWithOvershadowedStatus instance as equal or not? It's not clear to me right now which answer (yes or no) would be more useful to most callers. I guess it should be "yes" though since overshadowed isn't really "data". "Yes" for several reasons: 1) Liskov substitution principle 2) `overshadowed` is not "metadata" because it's not stored in the DB which is the principle of `allDataEquals` - after all, we introduce `allDataEquals` to fix #6358 which is about the data stored in the DB.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
