Fokko commented on issue #7810: Remove Apache Pig from the tests URL: https://github.com/apache/incubator-druid/pull/7810#issuecomment-498259772 @gianm Can you shed some light on the flattening part? I noticed that you've written parts of the original code. I do understand this one: https://github.com/apache/incubator-druid/blob/master/extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java#L113 Where you align the types that are being returned. For example, removing null's from a list, and changing an `Utf8` into a String type. However, this one looks awkward: https://github.com/apache/incubator-druid/blob/master/extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java#L120 Here we pass a `GenericRecord` into the JsonPath extraction function. It compiles since it accepts an `Object`, but it doesn't feel right. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
