surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r290448228
########## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ########## @@ -506,20 +477,7 @@ public boolean removeSegment(String dataSourceName, final String segmentId) public boolean removeSegment(SegmentId segmentId) Review comment: both these methods are used from `MetadataSegmentManager`, so not sure if I can remove it. I made the `removeSegment(String dataSourceName, final String segmentId)` call `removeSegment(SegmentId segmentId)` internally. The javadoc for these is in the interface `MetadataSegmentManager`, will add a note here that they do not update the snapshot now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
