jon-wei commented on a change in pull request #7588: multi-value string column
support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r290963944
##########
File path:
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
##########
@@ -155,15 +164,54 @@ public void inspectRuntimeShape(RuntimeShapeInspector
inspector)
}
}
- final Expr.ObjectBinding bindings = createBindings(expression,
columnSelectorFactory);
+ final Set<String> actualArrays = new HashSet<>();
Review comment:
maybe extract this block into a method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
