leventov commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r291682378
##########
File path: core/src/main/java/org/apache/druid/utils/CollectionUtils.java
##########
@@ -75,9 +76,9 @@ public int size()
* Returns a transformed map from the given input map where the value is
modified based on the given valueMapper
* function.
*/
Review comment:
To the list of things to address in a follow-up PR: highlight the difference
from `Maps.transformValues()` in the documentation, e. g. add a sentence like
`Unlike {@link Maps#transformValues}, this method applies the mapping function
eagerly to all key-value pairs in the source map and returns a new {@link
HashMap}, while {@link Maps#transformValues} returns a lazy map view.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
