vogievetsky opened a new pull request #7856: Web console: make the data loader 
more responsive when sampling data with many columns
URL: https://github.com/apache/incubator-druid/pull/7856
 
 
   This PR refactors the data loader so that the sample preview tables are in 
their own components.
   This has advantages in terms of pure code quality / testability / e.t.c, but 
the main reason for this change is performance.
   
   
![image](https://user-images.githubusercontent.com/177816/59154348-7ef63b00-8a25-11e9-9bf6-348f5eb1a29b.png)
   
   Currently editing the `Column` field in the screenshot above would feel very 
sluggish because with every keypress the entire table is being re-rendered and 
there is a lot of info in the table (many columns). This PR make each table in 
the data loader its own pure component (related: 
https://github.com/apache/incubator-druid/pull/7845) and leverages React to 
only render things when actually needed. The performance gain is drastic. Your 
browser/CPU will be happy.
   
   Also:
   
   - Fix up mkcomp script to be more upto date
   - Clean up stateless components
   - Move sql-control to just be part of the sql-view
   - More snapshot tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to