Fokko commented on a change in pull request #7810: Remove Apache Pig from the tests URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r291829413
########## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java ########## @@ -32,13 +32,8 @@ import java.util.function.Function; import java.util.stream.Collectors; -public class ObjectFlatteners +public abstract class ObjectFlatteners Review comment: Ah, I see now, it has just one static method. I was confused since it felt like an abstract class to me. Do you want to revert this? For me, it is an abstract class. I'm not a huge fan of the private constructor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
