vogievetsky commented on a change in pull request #7799: Web-console: update
supervisors table
URL: https://github.com/apache/incubator-druid/pull/7799#discussion_r291877705
##########
File path: web-console/src/views/task-view/tasks-view.tsx
##########
@@ -462,21 +466,27 @@ ORDER BY "rank" DESC, "created_time" DESC`);
show:
supervisorTableColumnSelectionHandler.showColumn('Topic/Stream')
},
{
- Header: 'Status',
+ Header: 'Detailed status',
id: 'status',
- accessor: (row) => row.spec.suspended ? 'Suspended' : 'Running',
- Cell: row => {
- const value = row.value;
+ width: 300,
+ accessor: (row) => {
+ const { status } = row;
+ if (!status) return '';
+ const { data } = status;
+ if (!data) return '';
+ const { payload } = data;
+ if (!payload) return '';
+ const value = payload.detailedState;
return <span>
<span
- style={{ color: value === 'Suspended' ? '#d58512' :
'#2167d5' }}
+ style={{ color: payload.healthy ? '#2167d5' : '#d5100a'}}
Review comment:
surely there are more statuses (and thus more colors) now. How does healthy
relate to detailed status?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
