vogievetsky commented on a change in pull request #7898: Web console: Add
download path to SQL Query
URL: https://github.com/apache/incubator-druid/pull/7898#discussion_r294026965
##########
File path: web-console/src/views/sql-view/sql-control/sql-control.tsx
##########
@@ -364,6 +370,15 @@ export class SqlControl extends
React.PureComponent<SqlControlProps, SqlControlS
{`Last query took ${(queryElapsed / 1000).toFixed(2)} seconds`}
</span>
}
+ {
+ queryElapsed &&
+ <Popover className="download-button" content={downloadMenu}
position={Position.BOTTOM_RIGHT}>
+ <Button
+ icon={IconNames.DOWNLOAD}
+ text="Download"
Review comment:
I think make this an icon only (no text, `minimal`) button
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
