Fokko commented on a change in pull request #7894: Add Spotbugs URL: https://github.com/apache/incubator-druid/pull/7894#discussion_r294338163
########## File path: dev/spotbugs-exclude.xml ########## @@ -0,0 +1,91 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +<FindBugsFilter> Review comment: Good point, I've moved the file to `codestyle/`. An all-exclusions would not work at all in my opinion, because that would require to fix all the violations at once, which is virtually undoable. In the situation where we enable one of the rules by a PR down the road. And let's say there is a PR which branched from a commit where this rule wasn't enabled yet (behind master), this will break the CI on the master branch with a spotbugs voilation. This isn't a huge issue since it will be a small change to get it fixed again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
