jihoonson commented on issue #7890: Set Test timeout higher for robust 
performance
URL: https://github.com/apache/incubator-druid/pull/7890#issuecomment-502786956
 
 
   There's nothing special in my test code. I just measured time elapsed in 
`SegmentManager.loadSegment()`.
   
   ```java
     @Test(timeout = 5000L)
     public void testLoadMultipleSegments() throws IOException, 
ExecutionException, InterruptedException
     {
       final List<DataSegment> segments = new ArrayList<>(88);
       for (int i = 0; i < 11; i++) {
         for (int j = 0; j < 8; j++) {
           
segments.add(createSegment(StringUtils.format("2019-%02d-01/2019-%02d-01", i + 
1, i + 2)));
         }
       }
   
       final List<Future> futures = IntStream
           .range(0, 16)
           .mapToObj(i -> exec.submit(() -> {
             for (DataSegment segment : segments) {
               try {
                 final long before = System.currentTimeMillis();
                 segmentManager.loadSegment(segment);
                 System.err.println(Thread.currentThread().getName() + ": " + 
(System.currentTimeMillis() - before) + " ms");
               }
               catch (SegmentLoadingException e) {
                 throw new RuntimeException(e);
               }
             }
           }))
           .collect(Collectors.toList());
       for (Future future : futures) {
         future.get();
       }
       Assert.assertEquals(11, segmentPuller.numFileLoaded.size());
       Assert.assertEquals(1, 
segmentPuller.numFileLoaded.values().iterator().next().intValue());
       Assert.assertEquals(0, segmentLoader.getSegmentLocks().size());
     }
   ```
   
   As I said earlier, I don't think it's normal if it takes ~100 ms to copy a 
single file with modern hardware. It took 0.304 sec even in Travis which runs 
those tests with limited resources in a [virtualized 
container](https://docs.travis-ci.com/user/reference/overview/). Since it seems 
that this problem is reproducible only in your test environment, please check 
what portion takes so long time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to