sashidhar commented on a change in pull request #7907: #7875: Setting ACL on S3 task logs on similar lines as that of data segments pushed to S3 URL: https://github.com/apache/incubator-druid/pull/7907#discussion_r295422953
########## File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3TaskLogsConfig.java ########## @@ -19,12 +19,14 @@ package org.apache.druid.storage.s3; +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; import com.fasterxml.jackson.annotation.JsonProperty; import javax.validation.constraints.NotNull; /** */ +@JsonIgnoreProperties(ignoreUnknown = true) Review comment: Added a new test class with two test cases testing the functionality of the bucket owner having full control permissions on the S3 task log files in that bucket. The permissions will be set as if disableAcl config is false. The test cases cover the cases with disableAcl true and false. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
