dclim commented on a change in pull request #7907: #7875: Setting ACL on S3 task logs on similar lines as that of data segments pushed to S3 URL: https://github.com/apache/incubator-druid/pull/7907#discussion_r295908902
########## File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3TaskLogsConfig.java ########## @@ -35,13 +35,32 @@ @NotNull private String s3Prefix = null; + @JsonProperty + private boolean disableAcl = false; + + public void setDisableAcl(boolean disableAcl) Review comment: This (and `setS3Bucket()`) don't strictly need to be public, but could be package-private (remove the modifier). Since they're currently only being used by tests, annotating them with `@VisibleForTesting` would also be a good practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
