clintropolis commented on a change in pull request #7958: expression virtual 
column selector fix for expressions which produce array types
URL: https://github.com/apache/incubator-druid/pull/7958#discussion_r297857457
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
 ##########
 @@ -498,7 +503,7 @@ public void inspectRuntimeShape(RuntimeShapeInspector 
inspector)
    */
   private static Object coerceListDimToStringArray(List val)
   {
-    Object[] arrayVal = 
val.stream().map(Object::toString).toArray(String[]::new);
+    Object[] arrayVal = val.stream().map(x -> x != null ? x.toString() : 
x).toArray(String[]::new);
 
 Review comment:
   I have some more follow-up work to do, will try to revisit and clean stuff 
up a bit more in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to