jihoonson commented on issue #5698: Oak: New Concurrent Key-Value Map URL: https://github.com/apache/incubator-druid/issues/5698#issuecomment-506097278 I think it would be nice if we have two benchmarks. One benchmark is for directly comparing performance of `OakIncrementalIndex` and `OnheapIncrementalIndex` (and optionally `OffheapIncrementalIndex` to show how optimized `OakIncrementalIndex` is to store data in off-heap memory). The benchmark result would include both ingestion throughput and latency to see how GC could affect to the ingestion performance. Another benchmark which is I think nice to have would measure the performance of `Appenderator`. `Appenderator` is a wrapper class of `IncrementalIndex` to hide the details of persisting intermediary segments into local disk, and is used by both native batch index task and Kafka/Kinesis index tasks. I think it would be a good benchmark to show how `OakIncrementalIndex` could make the ingestion performance better by testing production code path.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
