sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map 
URL: 
https://github.com/apache/incubator-druid/issues/5698#issuecomment-506257347
 
 
   @jihoonson , sounds good!
   
   > One benchmark is for directly comparing performance of OakIncrementalIndex 
and OnheapIncrementalIndex (and optionally OffheapIncrementalIndex to show how 
optimized OakIncrementalIndex is to store data in off-heap memory). 
   
   We have found OffheapIncrementalIndex not-optimized in some places, not so 
concurrent (synchronize on everything) and it looks like it not in use. Thus we 
decided not to compare to it as even in the tests/benchmarks there are some 
exceptions happening with OffheapIncrementalIndex....
   
   > The benchmark result would include both ingestion throughput and latency 
to see how GC could affect to the ingestion performance.
   
   Is it something like two graphs under "IncrementalIngestionBenchmark 
results" presented above? Is it the latency that you are missing? Or different 
parameters?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to