jon-wei commented on a change in pull request #7973: expression language array
constructor and sql multi-value string filtering support
URL: https://github.com/apache/incubator-druid/pull/7973#discussion_r298347153
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Calcites.java
##########
@@ -151,6 +151,9 @@ public static ValueType
getValueTypeForSqlTypeName(SqlTypeName sqlTypeName)
return ValueType.STRING;
} else if (SqlTypeName.OTHER == sqlTypeName) {
return ValueType.COMPLEX;
+ } else if (sqlTypeName == SqlTypeName.ARRAY) {
+ // until we have array ValueType, this let's us have array constants and
use them at least
Review comment:
let's -> lets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
