jon-wei commented on a change in pull request #7973: expression language array 
constructor and sql multi-value string filtering support
URL: https://github.com/apache/incubator-druid/pull/7973#discussion_r298351840
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
 ##########
 @@ -8085,4 +8085,71 @@ public void 
testMultiValueStringWorksLikeStringScanWithFilter() throws Exception
         )
     );
   }
+
+  @Test
 
 Review comment:
   Suggest adding a test where the array values are non-constant expressions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to