Fokko commented on issue #7998: Binary license management system URL: https://github.com/apache/incubator-druid/pull/7998#issuecomment-507140842 Great work @jihoonson. Thanks for picking this up. I fully agree with you; if it isn't checked by the CI, then it is hard to maintain. Maybe it is a good idea to add the lines on how to run the checker to the `CONTRIBUTING.md` file for further reference. One final note on the `findbugs` dependency. I'm looking for replacing this one with spotbugs: https://mvnrepository.com/artifact/com.github.spotbugs/spotbugs-annotations/3.1.12 But it looks like this one has the same issue with the wrong license. They are working on removing the JSR305 component: https://github.com/spotbugs/spotbugs/issues/421 but this will be tricky as we might expect.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
