himanshug commented on a change in pull request #7985: fail complex type
'serde' registration when registered type does not match expected type
URL: https://github.com/apache/incubator-druid/pull/7985#discussion_r299695689
##########
File path:
processing/src/main/java/org/apache/druid/segment/serde/ComplexMetrics.java
##########
@@ -38,12 +38,18 @@ public static ComplexMetricSerde getSerdeForType(String
type)
return complexSerializers.get(type);
}
- public static void registerSerde(String type, Supplier<ComplexMetricSerde>
serdeSupplier)
+ public static <T extends ComplexMetricSerde> void registerSerde(String type,
Class<T> clazz, Supplier<T> serdeSupplier)
{
- if (ComplexMetrics.getSerdeForType(type) == null) {
- if (complexSerializers.containsKey(type)) {
- throw new ISE("Serializer for type[%s] already exists.", type);
+ if (complexSerializers.containsKey(type)) {
+ if
(!complexSerializers.get(type).getClass().getCanonicalName().equals(clazz.getCanonicalName()))
{
Review comment:
can't we check the serde classname from
serdeSupplier.get().getClass().getName() ?
in fact, I am not sure if even taking a Supplier is necessary all of this
could possibly be done with original method signature which was
`registerSerde(String type, ComplexMetricSerde serde)` by using
`serde.getClass().getName()` or am I missing something ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
