jon-wei commented on a change in pull request #8011: add SQL docs for 
multi-value string dimensions
URL: https://github.com/apache/incubator-druid/pull/8011#discussion_r299717156
 
 

 ##########
 File path: docs/content/querying/multi-value-dimensions.md
 ##########
 @@ -280,11 +284,15 @@ returns following result.
 ]
 ```
 
-You might be surprised to see inclusion of "t1", "t2", "t4" and "t5" in the 
results. It happens because query filter is applied on the row before 
explosion. For multi-value dimensions, selector filter for "t3" would match 
row1 and row2, after which exploding is done. For multi-value dimensions, query 
filter matches a row if any individual value inside the multiple values matches 
the query filter.
+You might be surprised to see inclusion of "t1", "t2", "t4" and "t5" in the 
results. It happens because query filter is
 
 Review comment:
   It's not something new to this PR, but I think this area would be better 
with a plural "query filters"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to