sashidhar commented on a change in pull request #8038: Making optimal usage of
multiple segment cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#discussion_r301140082
##########
File path:
server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderLocalCacheManager.java
##########
@@ -102,6 +105,8 @@ public SegmentLoaderLocalCacheManager(
);
}
locations.sort(COMPARATOR);
Review comment:
@nishantmonu51 , This probably makes sense. However, one case is when the
segment cache location max sizes are skewed (one or few locations with way more
availability than others). The sort strategy resorts to selecting the same
location again and again until it's availability falls short of others. This
will end up having more or less the same behaviour reported in #7641.
Round-robin on the other hand will try to distribute the segments across
multiple locations there by improving I/O if the locations are backed by
different physical drives. However I'm not sure whether the round-robin
strategy has any implications on query performance. Let me know your thoughts.
@dclim and others, let us know your thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
