pdeva commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-509876442 Above benchmark doesn't take lock contention into account. The synchronized keyword has different performance characteristics based on how contended the lock is. The JIT will convert from thin to fat locks if the lock shows too much contention. if the lock has no contention, the overhead of synchronized keyword is negligible, but not zero, which is indeed shown in the benchmark above.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
