sashidhar commented on a change in pull request #7933: #7858 Throwing
UnsupportedOperationException from ImmutableDruidDataSource's equals() and
hashCode() methods
URL: https://github.com/apache/incubator-druid/pull/7933#discussion_r302675621
##########
File path:
server/src/main/java/org/apache/druid/client/ImmutableDruidDataSource.java
##########
@@ -120,8 +120,39 @@ public String toString()
+ "'}";
}
+ /**
+ *
+ * ImmutableDruidDataSource should be considered a container, not a data
class.
+ * The idea is the same as behind prohibiting/limiting equals() (and
therefore usage as HashSet/HashMap keys) of DataSegment: see #6358.
+ * When somebody wants to deduplicate ImmutableDruidDataSource objects, they
would need to put them into a Map<String, ImmutableDruidDataSource> and resolve
conflicts by name manually.
+ *
+ * See https://github.com/apache/incubator-druid/issues/7858
+ */
@Override
public boolean equals(Object o)
+ {
+ throw new UnsupportedOperationException("ImmutableDruidDataSource
shouldn't be used as the key in containers");
+ }
+
+ /**
+ *
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
