himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-510633717 @Eshcar thanks for pointing to that benchmark, that is the performance in ideal condition and specific to thetaSketch and aggregation methods typically do a little bit extra work and not just sketch op for managing things . However, I stand corrected that synchronization overhead is not necessarily always negligible compared to sketch operations and would depend on different aggregator implementations. @pdeva you are right that there is always a non-zero overhead even if little. hmmm.. I think, optimization proposed here might provide slight performance improvement for queries where multi million rows are scanned/merged and there were multiple sketch aggregators in the query. @gianm does that sound reasonable ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
