gianm commented on a change in pull request #8056: Add inline firehose
URL: https://github.com/apache/incubator-druid/pull/8056#discussion_r302751488
##########
File path:
server/src/test/java/org/apache/druid/segment/realtime/firehose/InlineFirehoseTest.java
##########
@@ -147,6 +152,7 @@ public void testCommit()
Assert.assertSame(Runnables.getNoopRunnable(), result);
}
+ @SuppressWarnings("squid:S00108") // Nested blocks of code should not be
left empty
Review comment:
This is a Sonar thing, and we don't currently use Sonar on a whole-community
level, so I'd leave this out for now. But please feel free to raise the
suggestion of using Sonar more broadly on the dev list, [email protected].
It looks like there is an ASF instance at: https://builds.apache.org/analysis/
that we could use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
