clintropolis commented on a change in pull request #8056: Add inline firehose
URL: https://github.com/apache/incubator-druid/pull/8056#discussion_r302789806
##########
File path: docs/content/ingestion/firehose.md
##########
@@ -176,39 +176,56 @@ Requires one of the following extensions:
|foldCase|Toggle case folding of database column names. This may be enabled in
cases where the database returns case insensitive column names in query
results.|false|No|
|sqls|List of SQL queries where each SQL query would retrieve the data to be
indexed.||Yes|
-#### Database
+### Database
|property|description|default|required?|
|--------|-----------|-------|---------|
|type|The type of database to query. Valid values are `mysql` and
`postgresql`_||Yes|
-|connectorConfig|specify the database connection properties via `connectURI`,
`user` and `password`||Yes|
+|connectorConfig|Specify the database connection properties via `connectURI`,
`user` and `password`||Yes|
+
+### InlineFirehose
+
+This Firehose can be used to read the data inlined in its own spec.
+It can be used for demos or for quickly testing out parsing and schema.
+A sample inline Firehose spec is shown below:
+
+```json
+{
+ "type": "inline",
+ "data": "0,values,formatted\n1,as,CSV"
+}
+```
+|property|description|required?|
+|--------|-----------|---------|
+|type|This should be "inline".|yes|
+|data|Inlined data to ingest.|yes|
### CombiningFirehose
-This firehose can be used to combine and merge data from a list of different
firehoses.
-This can be used to merge data from more than one firehose.
+This Firehose can be used to combine and merge data from a list of different
Firehoses.
+This can be used to merge data from more than one Firehose.
Review comment:
Same thing about not writing, but this 2nd sentence seems redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
