gianm commented on a change in pull request #8067: firehose doc adjustments
URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r303020482
##########
File path: docs/content/ingestion/firehose.md
##########
@@ -144,7 +142,10 @@ A sample ingest Firehose spec is shown below:
### SqlFirehose
-This Firehose can be used to ingest events residing in RDBMS. The database
connection information is provided as part of the ingestion spec. For each
query, the results are fetched locally and indexed. If there are multiple
queries from which data needs to be indexed, queries are prefetched in the
background upto `maxFetchCapacityBytes` bytes.
+This Firehose can be used to ingest events residing in an RDBMS. The database
connection information is provided as part of the ingestion spec.
+For each query, the results are fetched locally and indexed.
+If there are multiple queries from which data needs to be indexed, queries are
prefetched in the background, up to `maxFetchCapacityBytes` bytes.
+This firehose works with `map` typed parsers.
Review comment:
Btw, when I say example I mean something like this:
```
"parser": {
"type" : "map",
"parseSpec": {
"format": "timeAndDims",
"dimensionsSpec": {
"dimensions": [
"dim1",
"dim2",
"dim3"
]
},
"timestampSpec": {
"format": "auto",
"column": "ts"
}
}
}
```
(Posted in the Apache Druid Slack channel yesterday)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
