clintropolis commented on a change in pull request #8067: firehose doc adjustments URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r303056775
########## File path: docs/content/ingestion/firehose.md ########## @@ -119,10 +118,9 @@ The below configurations can be optionally used for tuning the Firehose performa ### IngestSegmentFirehose -This Firehose can be used to read the data from existing druid segments. -It can be used to ingest existing druid segments using a new schema and change the name, dimensions, metrics, rollup, etc. of the segment. +This Firehose can be used to read the data from existing druid segments, potentially using a new schema and changing the name, dimensions, metrics, rollup, etc. of the segment. This Firehose is _splittable_ and can be used by [native parallel index tasks](./native_tasks.html#parallel-index-task). -A sample ingest Firehose spec is shown below: +This firehose uses `map` typed parsers. A sample ingest Firehose spec is shown below: Review comment: I uh.. maybe? I referenced the ingest segment firehose unit tests which, which is using map parser with time and dims parsespec. I'll have another look and maybe change those other docs if that is not the case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
