drcrallen commented on issue #8083: Principle for treating configuration errors URL: https://github.com/apache/incubator-druid/issues/8083#issuecomment-511479641 I don't believe there is a single best way to handle wrong configuration. I propose the severity of the reaction be related to the detectability and impact of the failure mode. As a simple example, if I have a config option I know is coming in 0.16.0, and I put it in a config file for 0.15.0 knowing it will be ignored in that version, I expect the system to politely ignore the config. Likewise if a config option is deprecated in 0.15.0, and will be gone in 0.16.0, then the system should warn of the use of a deprecated option during the 0.15.0 transition release. Part of the reason I am against outright failure on *all* configuration problems is that there are many ways configurations can be odd and not actually a problem, and possibly even intended. I propose having an outright error only in cases where the system effectively says "You have not told me what to do and I have no reasonable default, or you have told me too many things to do and I can't reconcile them." Examples of the first case are things like passing in arrays when single values are required (parsing). Examples of the second are when multiple things are defined for a singleton. But even then that is only if they can't be reconciled (ex: just take the last one sequentially in the properties file)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
