clintropolis commented on a change in pull request #8085: fix forking task
runner task shutdown to be more graceful
URL: https://github.com/apache/incubator-druid/pull/8085#discussion_r303648357
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java
##########
@@ -714,6 +701,21 @@ private void saveRunningTasks()
}
}
+ private void shutdownTaskProcess(ForkingTaskRunnerWorkItem taskInfo)
Review comment:
It sort of seems like a misleading comment, since it doesn't call that
directly, it's just closing the stream of the forked task and destroying it if
that encounters an exception. Also since I am not entirely sure that lifecycle
stop _wasn't_ being called previously...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
