clintropolis opened a new pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName URL: https://github.com/apache/incubator-druid/pull/8086 ### Description This PR adds a checkstyle rule to forbid using `Class.getCanonicalName` in favor of `Class.getName` since the latter will not return null for anonymous types. One minor side-effect, this will cause cache misses on off machine/shared caches during upgrade since a few of the cache keys were created using canonical name previously, but this doesn't seem a huge deal to me. We can add exemptions to retain these if anyone feels strongly about this. See discussion [here](https://github.com/apache/incubator-druid/pull/7985#discussion_r299695689) <hr> This PR has: - [x] been self-reviewed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
