samarthjain opened a new pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100 ### Description This PR adds support for t-digest based sketch aggregators that was added in https://github.com/apache/incubator-druid/pull/7331 Additionally this PR removes previously added mergeTDigestSketch aggregator. The merging/combining functionality has been added in buildTDigestSketch aggregator. The docs also have been updated with the relevant changes. Note that a couple of tests added in this PR will fail till https://github.com/apache/incubator-druid/pull/8099 is merged. This PR has: - [X ] been self-reviewed. - [X ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ X] added documentation for new or modified features or behaviors. - [ X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [X ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ X] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ X] been tested in a test Druid cluster. For reviewers: the key changed/added classes in this PR are `TDigestGenerateSketchSqlAggregator`, and `TDigestSketchQuantileSqlAggregator`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
