jihoonson commented on a change in pull request #7653: Refactor
SQLMetadataSegmentManager; Change contract of REST methods in
DataSourcesResource
URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r304697261
##########
File path:
core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java
##########
@@ -75,12 +79,11 @@
Comparators.intervalsByStartThenEnd()
);
private final Map<Interval, TreeMap<VersionType, TimelineEntry>>
allTimelineEntries = new HashMap<>();
+ private final AtomicInteger numObjects = new AtomicInteger();
Review comment:
Or, this variable is used only in `iterateAllObjects`. Should it return a
collection? Or can we change the return type to Stream or Iterator? With this
change, we don't have to track the number of objects in the timeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
