leventov opened a new issue #8111: Fix concurrency of 
DerivativeDataSourceManager
URL: https://github.com/apache/incubator-druid/issues/8111
 
 
   - `derivativesRef` shouldn't be static
   - Seems that `derivativesRef` shouldn't be atomic; volatile would suffice. 
This looks like an example of 
https://github.com/code-review-checklists/java-concurrency#redundant-atomics
   - `derivativesRef` doesn't need to store a `ConcurrentHashMap`, a simple 
`HashMap` would suffice
   
   FYI @zhangxinyu1 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to