clintropolis commented on a change in pull request #8106: fix npe with sql
metadata manager polling and empty database
URL: https://github.com/apache/incubator-druid/pull/8106#discussion_r305552184
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -950,15 +950,11 @@ public DataSegment map(int index, ResultSet r,
StatementContext ctx) throws SQLE
}
);
- if (segments == null || segments.isEmpty()) {
- log.info("No segments found in the database!");
+ if (segments == null) {
Review comment:
`Preconditions` check makes sense to me, to control the error messaging here
instead of allowing the NPE to happen downstream, will update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
