clintropolis commented on a change in pull request #8113: Web console: cleanup
build, check licenses in test
URL: https://github.com/apache/incubator-druid/pull/8113#discussion_r305566148
##########
File path: web-console/package.json
##########
@@ -35,8 +35,7 @@
"scripts": {
"compile": "./script/build",
"pretest": "./script/build",
- "run": "./script/run",
- "test": "npm run tslint && npm run stylelint && jest --silent 2>&1",
+ "test": "npm run tslint && npm run stylelint && npm run check-licenses &&
jest --silent 2>&1",
Review comment:
It looks like this causes the license checker to be run twice during CI,
first by maven independently
https://travis-ci.org/apache/incubator-druid/jobs/561206509#L1293, and then by
side effect when maven runs test. We could probably remove the `check-licenses`
maven execution from the web-console pom.xml,
https://github.com/apache/incubator-druid/blob/master/web-console/pom.xml#L67,
though it's probably not a huge deal to leave in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
