esevastyanov commented on a change in pull request #8110: Response context
refactoring
URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305818660
##########
File path:
processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java
##########
@@ -151,12 +150,13 @@ public void close() throws IOException
);
}
- private void appendMissingSegment(Map<String, Object> responseContext)
+ private void appendMissingSegment(ResponseContext responseContext)
{
- List<SegmentDescriptor> missingSegments = (List<SegmentDescriptor>)
responseContext.get(Result.MISSING_SEGMENTS_KEY);
+ List<SegmentDescriptor> missingSegments =
Review comment:
Let me know if I should introduce these two methods to refactor a method
`appendMissingSegment`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
