gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306037681
########## File path: docs/content/configuration/index.md ########## @@ -1319,6 +1321,8 @@ You can optionally only configure caching to be enabled on the Historical by set |`druid.historical.cache.useCache`|true, false|Enable the cache on the Historical.|false| |`druid.historical.cache.populateCache`|true, false|Populate the cache on the Historical.|false| |`druid.historical.cache.unCacheable`|All druid query types|All query types to not cache.|["groupBy", "select"]| +|`druid.historical.cache.numBackgroundThreads`|If greater than 0, cache will be populated in the background thread pool of the configured size|0| Review comment: Due to the controversy about how to word the doc for background cache population, I'd suggest breaking that out into its own PR and leaving this one to only include the lock-removal fix for foreground cache population. These two things are only tangentially related. In the other PR, we could discuss: - Whether or not we are going to document background caching at this time (given the above thread). - What exactly the docs should say. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
