clintropolis commented on a change in pull request #8107: Add CliIndexer 
process type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306190435
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/initialization/ServerConfig.java
 ##########
 @@ -34,12 +34,45 @@
  */
 public class ServerConfig
 {
-
   public static final int DEFAULT_GZIP_INFLATE_BUFFER_SIZE = 4096;
 
+  public ServerConfig(
 
 Review comment:
   Should this be done as `@JsonCreator` to get rid of the need for the empty 
constructor or is there something in this that doesn't come from json?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to