leventov opened a new issue #5672: Elaborate the Cacheable.getCacheKey() spec and review the implementations URL: https://github.com/apache/incubator-druid/issues/5672 `Cacheable.getCacheKey()` must be elaborated, specifying what parts of the state of the `Cacheable` classes should or should not be included into the mix. Some exemplary implementations that are known to be correct should be linked. E. g. see the doc of `HotLoopCallee.inspectRuntimeShape()`, which is more specific on what parts of the state should be inspected. Along with this, all existing `getCacheKey()` implementations should be reviewed for conforming with the spec and ensuring that they don't have bugs at the moment.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
