gianm commented on a change in pull request #8128: Fix dependency analyze
warnings
URL: https://github.com/apache/incubator-druid/pull/8128#discussion_r306450217
##########
File path: .travis.yml
##########
@@ -43,7 +43,13 @@ matrix:
# Strict compilation requires more than 2 GB
script: MAVEN_OPTS='-Xmx3000m' mvn clean -Pstrict -pl '!benchmarks'
compile test-compile spotbugs:check -B --fail-at-end
- # packaging check
+ # analyze dependencies
Review comment:
Please add a comment here w/ rationale as to why we are doing this. (People
will appreciate being able to read that if the job fails on one of their PRs.)
Something that mentions what can go wrong if you use undeclared transitive
deps, and what can go _right_ if you avoid declaring deps you're not using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
