clintropolis commented on a change in pull request #8138: Add SuppressWarnings
SS_SHOULD_BE_STATIC
URL: https://github.com/apache/incubator-druid/pull/8138#discussion_r306549642
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
##########
@@ -29,6 +29,7 @@
/**
*/
+@SuppressWarnings("SS_SHOULD_BE_STATIC")
Review comment:
This doesn't seem to be working, travis is still failing with the same error
https://travis-ci.org/apache/incubator-druid/jobs/562722959#L1985:
```
[INFO] Total bugs: 3
[ERROR] Unread field:
org.apache.druid.indexing.worker.config.WorkerConfig.intermediaryPartitionCleanupPeriodSec;
should this field be static?
[org.apache.druid.indexing.worker.config.WorkerConfig] At
WorkerConfig.java:[line 50] SS_SHOULD_BE_STATIC
[ERROR] Unread field:
org.apache.druid.indexing.worker.config.WorkerConfig.intermediaryPartitionDiscoveryPeriodSec;
should this field be static?
[org.apache.druid.indexing.worker.config.WorkerConfig] At
WorkerConfig.java:[line 47] SS_SHOULD_BE_STATIC
[ERROR] Unread field:
org.apache.druid.indexing.worker.config.WorkerConfig.version; should this field
be static? [org.apache.druid.indexing.worker.config.WorkerConfig] At
WorkerConfig.java:[line 39] SS_SHOULD_BE_STATIC
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
