jon-wei commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r306595714
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -110,60 +80,143 @@ protected AbstractBatchIndexTask(
)
{
super(id, groupId, taskResource, dataSource, context);
+ segmentLockHelper = new SegmentLockHelper(dataSource);
}
- public abstract boolean requireLockInputSegments();
+ /**
+ * Return true if this task can overwrite existing segments.
+ */
+ public abstract boolean requireLockExistingSegments();
- public abstract List<DataSegment> findInputSegments(TaskActionClient
taskActionClient, List<Interval> intervals)
+ /**
+ * Find segments to lock in the given intervals.
+ * If this task is intend to overwrite only some segments in those
intervals, this method should return only those
+ * segments instead of entire segments in those intervals.
+ */
+ // TODO: remove this
Review comment:
Can you remove the TODO and link to an issue or comment that describes the
future work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
