leventov commented on a change in pull request #8138: Add SuppressWarnings
SS_SHOULD_BE_STATIC
URL: https://github.com/apache/incubator-druid/pull/8138#discussion_r306690529
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
##########
@@ -29,6 +29,7 @@
/**
*/
+@SuppressWarnings("SS_SHOULD_BE_STATIC")
Review comment:
In general, please
1) Make suppressions as local as possible: can suppress for individual
fields?
2) Explain a suppression with a comment: mention what does the rule mean
("SS_SHOULD_BE_STATIC" is not self-explanatory) and explain why it should be
suppressed in each particular case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
