himanshug commented on issue #8076: Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN URL: https://github.com/apache/incubator-druid/pull/8076#issuecomment-514834543 @Fokko please remove the pre-filled template from PR . descriptions , that is to guide contributors towards what to add in PR description. Keeping all of it in the PR is confusing. For example, this PR description should have been... --------- ### Description Suspicious reference comparison of Boolean values, Spotbugs rule RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN This method compares two Boolean values using the == or != operator. Normally, there are only two Boolean values (Boolean.TRUE and Boolean.FALSE), but it is possible to create other Boolean objects using the new Boolean(b) constructor. It is best to avoid such objects, but if they do exist, then checking Boolean objects for equality using == or != will give results than are different than you would get using .equals(...) <hr> This PR has: [x] been self-reviewed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
