clintropolis commented on a change in pull request #8124: Web-console: add
lookups tile to home view
URL: https://github.com/apache/incubator-druid/pull/8124#discussion_r307071123
##########
File path: web-console/src/views/home-view/home-view.tsx
##########
@@ -448,6 +479,18 @@ GROUP BY 1`,
),
error: state.serverCountError,
})}
+ {this.renderCard({
+ href: '#lookups',
+ icon: IconNames.PROPERTIES,
+ title: 'Lookups',
+ loading: state.lookupsCountLoading,
+ content: (
+ <>
+ <p>{pluralIfNeeded(state.lookupsCount, 'lookup')}</p>
+ </>
+ ),
+ error: state.lookupsUninitialized ? 'Lookups Uninitialized' :
state.lookupsCountError,
Review comment:
Should the panel render as `Error: Lookups Uninitialized` or could it be a
slightly more friendly `Lookups Uninitialized` (if it’s not a huge hassle)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
