clintropolis commented on a change in pull request #8067: sql firehose and
firehose doc adjustments
URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r307560908
##########
File path: core/src/main/java/org/apache/druid/data/input/impl/SqlFirehose.java
##########
@@ -35,18 +34,18 @@
public class SqlFirehose implements Firehose
{
private final Iterator<JsonIterator<Map<String, Object>>> resultIterator;
- private final InputRowParser parser;
+ private final MapInputRowParser parser;
private final Closeable closer;
private JsonIterator<Map<String, Object>> lineIterator = null;
public SqlFirehose(
- Iterator lineIterators,
- InputRowParser<Map<String, Object>> parser,
+ Iterator<JsonIterator<Map<String, Object>>> lineIterators,
+ InputRowParser parser,
Closeable closer
)
{
this.resultIterator = lineIterators;
- this.parser = parser;
+ this.parser = new MapInputRowParser(parser.getParseSpec());
Review comment:
Added transform handling and tests. This involved moving `SqlFirehose` and
some of it's friends out of `druid-core` and into `druid-server` and making
some stuff `public`. Thanks for catching this :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
