leventov opened a new issue #8167: Clarifying VersionedIntervalTimeline.findFullyOvershadowed() URL: https://github.com/apache/incubator-druid/issues/8167 In #7547, @jihoonson added clarifying comments for `completePartitionsTimeline` and `incompletePartitionsTimeline` fields in `VersionedIntervalTimeline`. One of the comments say that "IncompletePartitionsTimeline also includes completePartitionsTimeline". It explains to me why the second part of the `findFullyOvershadowed()` algorithm iterates only over `incompletePartitionsTimeline`: https://github.com/apache/incubator-druid/blob/7b9bd5359db80bdd9bb3f547161f94b369469b76/core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java#L392-L404 But it doesn't explain why then the first part does exactly the same loop over both `completePartitionsTimeline` and `incompletePartitionsTimeline`: https://github.com/apache/incubator-druid/blob/7b9bd5359db80bdd9bb3f547161f94b369469b76/core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java#L364-L382 Related to #7433 and #8070.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
