mohammadjkhan commented on a change in pull request #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r307897458
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/BasicHTTPAuthenticator.java
##########
@@ -67,19 +70,49 @@ public BasicHTTPAuthenticator(
@JsonProperty("initialInternalClientPassword") PasswordProvider
initialInternalClientPassword,
@JsonProperty("enableCacheNotifications") Boolean
enableCacheNotifications,
@JsonProperty("cacheNotificationTimeout") Long cacheNotificationTimeout,
- @JsonProperty("credentialIterations") Integer credentialIterations
+ @JsonProperty("credentialIterations") Integer credentialIterations,
+ @JsonProperty("skipOnFailure") Boolean skipOnFailure,
+ @JsonProperty("credentialsValidator") CredentialsValidator
credentialsValidator,
+ @JsonProperty("credentialsValidator.url") String url,
+ @JsonProperty("credentialsValidator.bindUser") String bindUser,
+ @JsonProperty("credentialsValidator.bindPassword") PasswordProvider
bindPassword,
+ @JsonProperty("credentialsValidator.baseDn") String baseDn,
+ @JsonProperty("credentialsValidator.userSearch") String userSearch,
+ @JsonProperty("credentialsValidator.userAttribute") String userAttribute,
+ @JsonProperty("credentialsValidator.groupFilters") String[] groupFilters,
+ @JsonProperty("credentialsValidator.credentialVerifyDuration") Integer
credentialVerifyDuration,
+ @JsonProperty("credentialsValidator.credentialMaxDuration") Integer
credentialMaxDuration,
+ @JsonProperty("credentialsValidator.credentialCacheSize") Integer
credentialCacheSize
Review comment:
Fixed, i've cleaned this up. credentialsValidator.* properties have been
moved inside corresponding credentials validator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]